Update Developer Setup Guide to include instructions on pulling submodules.#69
Merged
Update Developer Setup Guide to include instructions on pulling submodules.#69
Conversation
smalho01
previously approved these changes
Apr 10, 2023
Contributor
KeeyanGhoreshi
left a comment
KeeyanGhoreshi
left a comment
There was a problem hiding this comment.
we can ignore the failing tests for now since the switch to mocha should take care of the strange errors jest is giving.
When I pulled the submodule I had to run git submodule update --remote after the init to actually get the submodule on the branch I wanted it to be on. I think it might also be helpful to add a note about troubleshooting, since I had to use https to get it to run with git submodule sync.
smalho01
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update Developer Setup Guide to include instructions on pulling submodules.
Issue ticket number and Jira link
REMS-369
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.